nvme: Support show-regs for nvmeof #2521
Conversation
hmi-jeon
force-pushed
the
support-nvmeof-show-regs
branch
2 times, most recently
from
31614f7
to
2496a31
Compare
| void *bar; | ||
| int err; | ||
|
|
||
| struct get_reg_config cfg = { | ||
| .human_readable = false, | ||
| .fabrics = false, |
There was a problem hiding this comment.
This change doesn't seem necessary. nvme_get_properties operates only on offsets. Anyway, the whole logic is already a bit complex so I'd rather avoid this type of additional info passed into the getters.
There was a problem hiding this comment.
Yes. But If the device does not support NSSR, it will fail.
So If it is cfg.fabrics, In the nvme_get_single_property check optional register.
Is there a better fix?
Thanks.
There was a problem hiding this comment.
I see, we already use it. This is so horrible code. I shouldn't have merged it.
There was a problem hiding this comment.
Okay. I understood it.
As you said, it looks like refactoring is needed.
hmi-jeon
force-pushed
the
support-nvmeof-show-regs
branch
2 times, most recently
from
9e234cc
to
40393af
Compare
|
Thanks! We should though rethink this part of the code. Really messy how it currently is. |
Get properties only at offsets that support nvme fabric registers. Since crto was not found in the nvmeof spec, it is removed. Also, NSSR is only optional register. If the device is not supported by the optional register, the error is ignored. Reviewed-by: Steven Seungcheol <[email protected]> Signed-off-by: Minsik Jeon <[email protected]>
Get properties only at offsets that support nvme fabric registers.
Since crto was not found in the nvmeof spec, it is removed.
Also, NSSR is only optional register. If the device is not supported by the optional register, the error is ignored.
Reviewed-by: Steven Seungcheol [email protected]
Signed-off-by: Minsik Jeon [email protected]