Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVME_CSI_KV implemented #2480

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

laiaferrer
Copy link

@laiaferrer laiaferrer commented Aug 26, 2024

type: KV Command Set Log Page

Case KV, CSI = 1 implemented. So instead of Unknown it is being printed KV Command Set Log Page

Signed-off-by: rick <[email protected]>
@igaw igaw self-requested a review September 9, 2024 07:01
Copy link
Collaborator

@igaw igaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be one commit with a proper commit message.

@@ -3873,7 +3873,7 @@ static void stdout_effects_log_page(enum nvme_csi csi,
break;
default:
printf("Unknown Command Set Log Page\n");
printf("%-.80s\n", dash);
printf("%-.80s\n", dash);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't change anything, it just adds an empty space at the end of the line.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted the space on the last commit and also changed the commit message.

Case NVME_CSI_KV implemented, now it prints KV Command Set Log Page

Signed-off-by: laiaferrer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants