Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins/sed: add sid password change #2467

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gjoyce-ibm
Copy link

The existing ioctl to change password only updated the admin1 password. Add using a new ioctl IOC_OPAL_SET_SID_PW to also update the sid password so that sid and admin1 passwords are kept in sync.

The existing ioctl to change password only updated the admin1 password.
Add using a new ioctl IOC_OPAL_SET_SID_PW to also update the sid password
so that sid and admin1 passwords are kept in sync.

Signed-off-by: Greg Joyce <[email protected]>
@igaw
Copy link
Collaborator

igaw commented Aug 19, 2024

Looks good to me. Let's wait until the matching kernel code has been merged.

@igaw
Copy link
Collaborator

igaw commented Sep 16, 2024

I might have missed the kernel change, is this still the last version:

https://lore.kernel.org/all/[email protected]

@gjoyce-ibm
Copy link
Author

I might have missed the kernel change, is this still the last version:

https://lore.kernel.org/all/[email protected]

Yes. That's the last version. No code changes but I added to the description and added a reference to this pull request.

In three weeks there have been no comments on the resend.

@igaw
Copy link
Collaborator

igaw commented Sep 18, 2024

I'll bring this up at Linux Plumbers or at Alpss next week. Let's see if this helps.

@gjoyce-ibm
Copy link
Author

I'll bring this up at Linux Plumbers or at Alpss next week. Let's see if this helps.

Any discussions?

@igaw
Copy link
Collaborator

igaw commented Oct 1, 2024

Yes I discussed it with Keith and he was somewhat familiar with the protocol. I was not able to remember the details why this is necessary but he said he didn't really mind the change though, IIRC.

Let me ping him again here, @keithbusch would you mind to queue up or review these patches: https://lore.kernel.org/all/[email protected]

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants