RFC: xnvme backend support #1873
Conversation
…rivers, io_uring command on Linux. As well as using nvme-cli natively on FreeBSD. This is done by dispatching commands to xNVMe. Signed-off-by: Vikash kumar <[email protected]>
| @@ -49,6 +49,7 @@ libnvme_dep = dependency('libnvme', version: '>=1.3', required: true, | |||
| fallback : ['libnvme', 'libnvme_dep']) | |||
| libnvme_mi_dep = dependency('libnvme-mi', required: true, | |||
| fallback : ['libnvme', 'libnvme_mi_dep']) | |||
| libxnvme_dep = dependency('xnvme', version: '>=0.2.0', required: true) | |||
There was a problem hiding this comment.
This should be guarded by meson option setup option to disable it completely, see json-c as example. Some folks really don't like if we add hard dependencies.
| @@ -20,8 +20,8 @@ | |||
| */ | |||
| #define do_admin_op(op, d, ...) ({ \ | |||
| int __rc; \ | |||
| if (d->type == NVME_DEV_DIRECT) \ | |||
| __rc = nvme_ ## op(d->direct.fd, __VA_ARGS__); \ | |||
| if (d->type == NVME_DEV_DIRECT || d->type == NVME_DEV_XNVME) \ | |||
There was a problem hiding this comment.
The complete nvme-wrap.c file shouldn't be needed after introducing the transport abstraction.
| } | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Please avoid doing whitespace changes or adding too many newlines here.
| } | ||
|
|
||
|
|
||
|
|
||
| static int get_dev(struct nvme_dev **dev, int argc, char **argv, int flags) |
There was a problem hiding this comment.
I thought we are going to use the newly introduce transport abstraction from the library through out nvme-cli? Ideally we have this open device in libnvme, no?
| @@ -5535,8 +5575,8 @@ static int set_property(int argc, char **argv, struct command *cmd, struct plugi | |||
| } | |||
|
|
|||
| struct nvme_set_property_args args = { | |||
| .hnd = dev_fd(dev), | |||
There was a problem hiding this comment.
dev_fd should be renamed of course.
| @@ -69,15 +66,15 @@ struct nvme_dev { | |||
|
|
|||
| #define dev_fd(d) __dev_fd(d, __func__, __LINE__) | |||
|
|
|||
| static inline int __dev_fd(struct nvme_dev *dev, const char *func, int line) | |||
| static inline struct dev_handle* __dev_fd(struct nvme_dev *dev, const char *func, int line) | |||
There was a problem hiding this comment.
as previously said, this function should be renamed.
|
Created new PR addressing review comments |
Extended “struct nvme_dev” with the following device-handle types:
The ‘dev_handle' contains ‘struct xnvme_dev*’, file-descripter and ‘nvme_dev_type’ to manage library-side dispatch.
Adding ‘open_dev_xnvme(struct nvme_dev **devp, char *devname)’ function to open xNVMe library device handle and same being passed to ‘libnvme’ through ‘struct dev_handle’.
This xnvme plugin can work on different platform such as linux, freebsd and even windows. As well as this can work with different driver on linux(kernel and userspace driver such as SPDK)
Note: this will require libnvme changes, which can be found here
linux-nvme/libnvme#600