Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: xnvme backend support #600

Closed
wants to merge 4 commits into from
Closed

RFC: xnvme backend support #600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7bae6ee
doc: add ',' to meson-build
vikash-k5 Feb 23, 2023
4ec7f6b
meson: adjust formating -- add trailing ','
vikash-k5 Feb 23, 2023
eac2ddd
api: refactor for transport agnostic library backend
vikash-k5 Feb 24, 2023
50b2ada
build,ioctl: add xNVMe as transport-agnostic command-path / backend #wip
vikash-k5 Feb 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ api_files = [
'tree.h',
'types.h',
'fabrics.h',
'util.h'
'util.h',
]

api_paths = []
Expand Down
3 changes: 3 additions & 0 deletions meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ else
endif
conf.set('CONFIG_JSONC', json_c_dep.found(), description: 'Is json-c required?')

# Check for libxnvme availability
libxnvme_dep = dependency('xnvme', version: '>=0.2.0', required: true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this dependency optional, this might pull in whole set of secondary dependencies that might not be suitable for some systems. Think of initramfs usage, different init systems (linux is not only about systemd) and constrained embedded environments.


# Check for OpenSSL availability
openssl_dep = dependency('openssl',
version: '>=1.1.0',
Expand Down
1 change: 1 addition & 0 deletions src/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ endif
deps = [
json_c_dep,
openssl_dep,
libxnvme_dep,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without introducing the dependency object libxnvme_dep this will not work.

]

mi_deps = [
Expand Down
Loading