Disallow configuring a custom root CA with a custom RoundTripper #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yec-akamai
added
the
improvement
yec-akamai
requested review from
lgarber-akamai and
ykim-1
and removed request for
a team
| @@ -743,6 +744,11 @@ func NewClient(hc *http.Client) (client Client) { | |||
| log.Fatalf("[ERROR] Error when reading cert at %s: %s\n", certPath, err.Error()) | |||
| } | |||
|
|
|||
| if hc.Transport != http.DefaultTransport.(*http.Transport) { | |||
| log.Println("[WARN] Custom transport is not allowed with a custom root CA.") | |||
| return | |||
There was a problem hiding this comment.
Would it make sense to break this logic out into a separate function so the Client can still finish initializing if this condition is met?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Disallow that presenting custom root CA and custom http transport together. Print a warning and return when this happens.
✔️ How to Test