Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate OBJ Clusters List and View Functions #517

Conversation

zliang-akamai
Copy link
Member

📝 Description

This is to deprecate the Object Storage Clusters List and Cluster View API.

Test is not needed because only comments/in-line docs were changed.

@zliang-akamai zliang-akamai requested a review from a team as a code owner June 5, 2024 02:59
@zliang-akamai zliang-akamai requested review from lgarber-akamai and ykim-1 and removed request for a team June 5, 2024 02:59
@zliang-akamai zliang-akamai changed the title Zhiwei/deprecate clusters list and view Deprecate OBJ Clusters List and View Functions Jun 5, 2024
@lgarber-akamai
Copy link
Contributor

lgarber-akamai commented Jun 5, 2024

@zliang-akamai Assuming we're still waiting to deprecate the cluster endpoints until GA, would it make sense to add a temporary do not merge tag to this PR?

@zliang-akamai
Copy link
Member Author

@lgarber-akamai MultiCluster GA is 3 days after LA, so I think we are targeting GA to release everything now.

Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@zliang-akamai zliang-akamai changed the base branch from main to proj/multicluster-obj June 6, 2024 18:30
Copy link
Contributor

@ykim-1 ykim-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Nice work!

@zliang-akamai zliang-akamai merged commit cfad287 into linode:proj/multicluster-obj Jun 7, 2024
4 checks passed
@zliang-akamai zliang-akamai deleted the zhiwei/deprecate-clusters-list-and-view branch June 7, 2024 18:56
zliang-akamai added a commit that referenced this pull request Jul 9, 2024
* Add MultiCluster API changes support for key and bucket structs (#516)

* Deprecate OBJ Clusters List and View Functions (#517)

* Mark ListObjectStorageClusters and GetObjectStorageCluster as deprecated

* format code

* Update deprecated warning wording

Co-authored-by: Lena Garber <[email protected]>

* Update deprecated warning wording

Co-authored-by: Lena Garber <[email protected]>

---------

Co-authored-by: Lena Garber <[email protected]>

* Deprecated OBJ Cluster Fields (#524)

* Fix typo

---------

Co-authored-by: Lena Garber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants