Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e workflow #70

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

zliang-akamai
Copy link
Member

📝 Description

This is to fix the E2E workflow

✔️ How to Test

Test result: https://github.com/zliang-akamai/go-metadata/actions/runs/11506089637/job/32029239414
The failure above was caused by TOD uploading, rather than E2E itself, because I can't setup TOD in my fork.

@zliang-akamai zliang-akamai requested a review from a team as a code owner October 24, 2024 19:32
@zliang-akamai zliang-akamai requested review from lgarber-akamai and ykim-1 and removed request for a team October 24, 2024 19:32
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well on my fork, nice work!

For the TOD failure, would it make sense to split the test result upload out into a separate job like we do in Terraform or add an condition to only run the upload if the repo is under the Linode namespace?

Copy link
Contributor

@ykim-1 ykim-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up

@ykim-1
Copy link
Contributor

ykim-1 commented Oct 25, 2024

Works well on my fork, nice work!

For the TOD failure, would it make sense to split the test result upload out into a separate job like we do in Terraform or add an condition to only run the upload if the repo is under the Linode namespace?

I can create a ticket to improve the workflow including the condition you mentioned and slack notifications for both go/py metadata

@zliang-akamai zliang-akamai merged commit 3c72f4b into linode:main Oct 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants