[improvement] : store subnet id in linodeVPC and remove GetVPC call #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #548 +/- ##
==========================================
+ Coverage 63.78% 63.95% +0.16%
==========================================
Files 79 79
Lines 5575 5573 -2
==========================================
+ Hits 3556 3564 +8
+ Misses 1738 1730 -8
+ Partials 281 279 -2 ☔ View full report in Codecov by Sentry. |
rahulait
force-pushed
the
remove-getvpc-call
branch
3 times, most recently
from
cf72646
to
3ba174e
Compare
komer3
reviewed
Oct 24, 2024
api/v1alpha2/linodevpc_types.go
Outdated
| @@ -54,6 +53,9 @@ type VPCSubnetCreateOptions struct { | |||
| Label string `json:"label,omitempty"` | |||
| // +optional | |||
| IPv4 string `json:"ipv4,omitempty"` | |||
| // ID is subnet id for the subnet | |||
| // +optional | |||
| ID int `json:"id,omitempty"` | |||
There was a problem hiding this comment.
question: would it make more sense to call this subnetID?
There was a problem hiding this comment.
sorry to chime in on this late, I don't have a strong opinion here(and I think we break this other places as well) but for what it's worth subnet.subnetID is redundant but I'm fine with keeping it if that is the standard we have elsewhere, just wanted to call that out
rahulait
force-pushed
the
remove-getvpc-call
branch
from
7e668fe
to
f4c826b
Compare
eljohnson92
previously approved these changes
Oct 24, 2024
AshleyDumaine
previously approved these changes
Oct 24, 2024
rahulait
dismissed stale reviews from AshleyDumaine, eljohnson92, and komer3
via
289b4f6
komer3
approved these changes
Oct 24, 2024
AshleyDumaine
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR enables us to store subnet id in linodeVPC spec. This is useful as now we can rely on linodeVPC spec for subnet id than making a linode API call to get subnet id for the VPC.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: