-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improvement] : store subnet id in linodeVPC and remove GetVPC call #548
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #548 +/- ##
==========================================
+ Coverage 63.78% 63.95% +0.16%
==========================================
Files 79 79
Lines 5575 5573 -2
==========================================
+ Hits 3556 3564 +8
+ Misses 1738 1730 -8
+ Partials 281 279 -2 ☔ View full report in Codecov by Sentry. |
cf72646
to
3ba174e
Compare
api/v1alpha2/linodevpc_types.go
Outdated
@@ -54,6 +53,9 @@ type VPCSubnetCreateOptions struct { | |||
Label string `json:"label,omitempty"` | |||
// +optional | |||
IPv4 string `json:"ipv4,omitempty"` | |||
// ID is subnet id for the subnet | |||
// +optional | |||
ID int `json:"id,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: would it make more sense to call this subnetID?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry to chime in on this late, I don't have a strong opinion here(and I think we break this other places as well) but for what it's worth subnet.subnetID
is redundant but I'm fine with keeping it if that is the standard we have elsewhere, just wanted to call that out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
7e668fe
to
f4c826b
Compare
289b4f6
What this PR does / why we need it:
This PR enables us to store subnet id in linodeVPC spec. This is useful as now we can rely on linodeVPC spec for subnet id than making a linode API call to get subnet id for the VPC.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: