[Fix] Update the failure setting logic in Linode Machine Controller #543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a condition to not set Failure for linodemachine if the error is transient. This makes sure that Machine resource state is not set to failed unless a non transient error occurs
Previously, if there was an err emitted by the reconciler we would set a failure for LinodeMachine object which was causing the Machine resource to be set to
failed
and stay like that even if the linodemachine eventually comes ready.With the fix, we are not setting a failure if the emitted err is a transient error (meaning a temporary error which can change after re-queuing the request). We are now going to only set it if its a permanent error!
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: