[fix]: check provisioning -> running every 15 secs instead of 5 #472
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It looks like we are too aggressive in checking whether the instance has moved from provisioning -> running state. When an instance is created, it comes up, gets its disks created and resized, boots up and finally becomes running. This operation itself takes 1 to 2 mins based on the size of instance and other factors. Currently during reconcile, we are checking if instance has moved from provisioning to running state every 5 secs. This means for each instance, we are making close to 12 to 20 GET calls. Here is a sample output for one instance:
Based on the above logs, we can see that we are too aggressive in checking whether the instance has provisioned and moved to running or not. Instead of trying every 5 seconds, we can try every 15 seconds and that will cut down the number of GET api calls we make during instance creation to 1/3 of the existing number. I am suggesting 15 instead of 10 as I feel 15 is reasonable time to wait and then try again than being too aggressive.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: