Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] fix etcd-backup-restore based flavors #471

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

amold1
Copy link
Contributor

@amold1 amold1 commented Aug 20, 2024

What this PR does / why we need it:
CAPL clusterrs with etcd-backup-restore and related flavors fail to created. This is down to some recent OBJ changes for key names and namespaces within the secrets.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.33%. Comparing base (98b4e79) to head (20ede2e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #471   +/-   ##
=======================================
  Coverage   65.33%   65.33%           
=======================================
  Files          80       80           
  Lines        4192     4192           
=======================================
  Hits         2739     2739           
  Misses       1243     1243           
  Partials      210      210           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@unnatiagg
Copy link
Contributor

LGTM. Just a question @bcm820 for my understanding, the keys and bucket can be in different namespaces? From the PR I see, the secrets of type=addons.cluster.x-k8s.io/resource-set should always be created in namespace=kube-system. Was there any specific reason why it was removed in the first place?

@amold1
Copy link
Contributor Author

amold1 commented Aug 21, 2024

LGTM. Just a question @bcm820 for my understanding, the keys and bucket can be in different namespaces? From the PR I see, the secrets of type=addons.cluster.x-k8s.io/resource-set should always be created in namespace=kube-system. Was there any specific reason why it was removed in the first place?

That is hard-coded because that secret is only meant for backup-restore and the backup-restore pod is hardcoded to be in the kube-system namespace

@amold1 amold1 merged commit 56faeae into main Aug 21, 2024
13 checks passed
@eljohnson92 eljohnson92 deleted the fix.etcd-backup-restore branch September 20, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants