[fix] [improvement] move apiserver loadbalancing logic from linodemachine controller to linodecluster controller #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #457 +/- ##
==========================================
- Coverage 65.33% 64.53% -0.81%
==========================================
Files 80 81 +1
Lines 4192 4196 +4
==========================================
- Hits 2739 2708 -31
- Misses 1243 1278 +35
Partials 210 210 ☔ View full report in Codecov by Sentry. |
amold1
changed the title
|
Changes look good to me, can you rebase off main and squash @amold1 ? 🙏 |
cloud/services/loadbalancers.go
Outdated
| portsToBeAdded = append(portsToBeAdded, map[string]int{"configID": *portConfig.NodeBalancerConfigID, "port": portConfig.Port}) | ||
| } | ||
|
|
||
| logger.Info("abir", "portsToBeAdded", portsToBeAdded) |
There was a problem hiding this comment.
whoops, missed leftover debugging
rebased and checks running now - I'll "squash and merge" on approval |
AshleyDumaine
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For APIServer LoadBalancing, we are currently creating NB or DNS entries from the LinodeMachine controller causing inconsistencies during the creation/deletion process leading to either failed attempts to create a cluster or some DNS Entries being left behind. We had also turned off concurrency to mitigate these issues but that hasn't proven to be a good solution.
This PR now moves all of the logic to the LinodeCluster controller allowing it to accurately access what DNS entries or NB backends need to be added or deleted.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: