Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add finalizer to credentials reference #288

Merged
merged 3 commits into from
May 2, 2024

fix: linodevpc: add finalizer to credentials reference

286ac18
Select commit
Loading
Failed to load commit list.
Merged

fix: add finalizer to credentials reference #288

fix: linodevpc: add finalizer to credentials reference
286ac18
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 2, 2024 in 1s

64.87% (+0.47%) compared to 2f81203

View this Pull Request on Codecov

64.87% (+0.47%) compared to 2f81203

Details

Codecov Report

Attention: Patch coverage is 75.00000% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 64.87%. Comparing base (2f81203) to head (286ac18).

Files Patch % Lines
controller/linodecluster_controller.go 0.00% 6 Missing and 3 partials ⚠️
controller/linodemachine_controller.go 0.00% 8 Missing and 1 partial ⚠️
controller/linodevpc_controller.go 0.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
+ Coverage   64.40%   64.87%   +0.47%     
==========================================
  Files          30       30              
  Lines        1750     1842      +92     
==========================================
+ Hits         1127     1195      +68     
- Misses        574      592      +18     
- Partials       49       55       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.