Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix release #261

Merged
merged 1 commit into from
Apr 18, 2024
Merged

fix release #261

merged 1 commit into from
Apr 18, 2024

Conversation

eljohnson92
Copy link
Collaborator

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@eljohnson92 eljohnson92 marked this pull request as ready for review April 18, 2024 20:15
Copy link
Contributor

@rahulait rahulait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.83%. Comparing base (3674b72) to head (9eee217).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #261   +/-   ##
=======================================
  Coverage   53.83%   53.83%           
=======================================
  Files          27       27           
  Lines        1566     1566           
=======================================
  Hits          843      843           
  Misses        673      673           
  Partials       50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eljohnson92 eljohnson92 merged commit 845f05b into main Apr 18, 2024
8 checks passed
@eljohnson92 eljohnson92 deleted the fix-release branch April 18, 2024 20:22
AshleyDumaine pushed a commit that referenced this pull request Apr 19, 2024
amold1 pushed a commit that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants