adapt linodecluster controller tests to new mocktest changes (#277)

* adapt linodecluster controller tests to new mocktest changes
linode · Apr 26, 2024 · 30d4e89 · 30d4e89
1 parent b44a6d4
commit 30d4e89
Show file tree

Hide file tree

Showing 3 changed files with 190 additions and 214 deletions.
diff --git a/cloud/scope/cluster.go b/cloud/scope/cluster.go
@@ -72,7 +72,7 @@ func NewClusterScope(ctx context.Context, apiKey string, params ClusterScopePara
 	}
 
 	return &ClusterScope{
-		client:        params.Client,
+		Client:        params.Client,
 		Cluster:       params.Cluster,
 		LinodeClient:  linodeClient,
 		LinodeCluster: params.LinodeCluster,
@@ -82,7 +82,7 @@ func NewClusterScope(ctx context.Context, apiKey string, params ClusterScopePara
 
 // ClusterScope defines the basic context for an actuator to operate upon.
 type ClusterScope struct {
-	client        K8sClient
+	Client        K8sClient
 	PatchHelper   *patch.Helper
 	LinodeClient  LinodeNodeBalancerClient
 	Cluster       *clusterv1.Cluster

diff --git a/controller/linodecluster_controller.go b/controller/linodecluster_controller.go
@@ -192,6 +192,7 @@ func (r *LinodeClusterReconciler) reconcileDelete(ctx context.Context, logger lo
 	if clusterScope.LinodeCluster.Spec.Network.NodeBalancerID == nil {
 		logger.Info("NodeBalancer ID is missing, nothing to do")
 		controllerutil.RemoveFinalizer(clusterScope.LinodeCluster, infrav1alpha1.GroupVersion.String())
+		r.Recorder.Event(clusterScope.LinodeCluster, corev1.EventTypeWarning, "NodeBalancerIDMissing", "NodeBalancer ID is missing, nothing to do")
 
 		return nil
 	}