New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test enhancement #5

Open

peter279k wants to merge 1 commit into linna:master from peter279k:test_enhancement

Member

peter279k commented Mar 26, 2019

Changed log

Remove php-7.3-RC because the php-7.3 has been released by official PHP.
Using the assertFalse to check whether the expected result is false.
Using the assertIsInt to check whether expected value type is int.
Using the short array syntax for test cases because of consistency.
Replace if-else condition with ?: and single statement to enhance the conditional statement.


          Test enhancement

327bdde

peter279k force-pushed the test_enhancement branch from 6febf92 to 327bdde Compare

March 26, 2019 04:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet