Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle failures in cache.add(), cache.set_multi() #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle failures in cache.add(), cache.set_multi() #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions django_ft_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@ def wrapper(*args, **kwargs):
except Exception as err:
logger.error(u"cache.%s failed with args: %s", f.__name__, args)
logger.exception(err)
result = None
if f.__name__ == 'set_multi':
# set_multi() returns a list of failed keys. Pretend that none have failed.
result = []
else:
result = None
return result
return wrapper

Expand All @@ -25,7 +29,7 @@ class FaultTolerantCacheMixin(object):
Wraps memcache client methods allowing them to fail
without raising an exception.
"""
methods_to_patch = ('get', 'set', 'incr', 'decr', 'delete',
methods_to_patch = ('add', 'get', 'set', 'incr', 'decr', 'delete',
'get_multi', 'set_multi', 'delete_multi')

@cached_property
Expand Down