Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Make import path replacement hack more reliable #83

Conversation

janopae
Copy link

@janopae janopae commented Oct 1, 2023

Instead of replacing the string src in the file bin/trelby with the actual location of src on the target platform when installing, we now replace the string "src". This is because sometimes, the replacement seems to happen multiple times, and we want to prevent replacing all occurrences of src in the target path again and again.

This is basically a hack inside a hack, but we want to modernise the installation process anyway (see #75), which might avoid these kinds of hacks in general.

@janopae
Copy link
Author

janopae commented Oct 1, 2023

@limburgher does this fix #82?

Sadly, I didn't get to run debuild on my machine and therefore never tested building .deb packages.

@limburgher
Copy link
Owner

It does not.

@janopae
Copy link
Author

janopae commented Oct 4, 2023

Is the resulting bin/trelby file the same as described in #82?

@limburgher
Copy link
Owner

It is.

@limburgher
Copy link
Owner

Please close this PR and reopen again https://github.com/trelby/trelby, as the project is merging into that project. Thank you!

@limburgher limburgher closed this Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants