This repository has been archived by the owner on Dec 22, 2023. It is now read-only.
Fix loading of custom fonts #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Load fonts in binary mode, because font files aren't encoded strings. Fix parseFunc tables encoding
by fixing parseFunc tables encoding
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first half of resolving #9. This PR fixes the parsing and validating of .ttf files, and therefore enables you to load a font file and set it as a font for your screenplay. Rendering PDFs with the font however still doesn't work, as the binary blob of the file still won't properly be included into the PDF file. However, I don't consider that last part worth fixing, as it will be automatically resolved by #59.