Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alerts: add description to alert.alerting_rule's id field #188

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Conversation

mattcarmody
Copy link
Contributor

There was no description for the id field for an alerting_rule embedded in a unified alert. This was causing the docs generator to assume it is a Read-Only field representing an alerting_rule's unique identifier, which is incorrect.

@mattcarmody mattcarmody requested review from robswhitmore, a team and rkuchan October 18, 2023 19:57
@ltyson ltyson merged commit ee48777 into main Oct 19, 2023
5 checks passed
@ltyson ltyson deleted the carmody-docs branch October 19, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants