Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus exporter: use explicit histograms #777

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Conversation

isaaczinda
Copy link
Contributor

@isaaczinda isaaczinda commented Sep 21, 2024

The current prometheus exporter can't export histograms. This is because the current converter passes the prometheus exporter exponential histograms, which it doesn't know how to accept. This PR teaches the converter to produce explicit histograms instead, which the prometheus exporter does know how to accept.

Testing:

  • a simple integration test to makes sure the /metrics endpoint can produce is exposing histogram points
  • fairly involved unit tests of the converter from lightstep histogram to OTel explicit histogram

R: @jmacd

@isaaczinda isaaczinda marked this pull request as ready for review September 23, 2024 18:05
@jmacd jmacd merged commit ec020ef into main Sep 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants