Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add WithRenameFunction() view ClauseOption #504

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

kristinapathak
Copy link
Contributor

@kristinapathak kristinapathak commented Aug 3, 2023

Description: Add a more flexible way to rename metrics when multiple instruments are matching on the same regular expression.

Link to tracking Issue: #505

Testing: Current unit tests for WithName() also test the new WithRenameFunction() due to WithName() using it. I can add more tests if desired.

Documentation: comments

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (c94b43c) 89.40% compared to head (7b0d962) 89.39%.

❗ Current head 7b0d962 differs from pull request most recent head 764e1c6. Consider uploading reports for the commit 764e1c6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
- Coverage   89.40%   89.39%   -0.01%     
==========================================
  Files          62       62              
  Lines        3595     3593       -2     
==========================================
- Hits         3214     3212       -2     
  Misses        287      287              
  Partials       94       94              
Files Changed Coverage Δ
lightstep/sdk/metric/view/views.go 100.00% <ø> (ø)
...ghtstep/sdk/metric/internal/viewstate/viewstate.go 97.68% <100.00%> (-0.02%) ⬇️
lightstep/sdk/metric/view/clause.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kristinapathak kristinapathak marked this pull request as ready for review August 7, 2023 20:52
@kristinapathak kristinapathak merged commit 2b042b7 into main Aug 7, 2023
1 check passed
@kristinapathak kristinapathak deleted the add-metric-view-option branch August 7, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants