Use TBinaryProtocolAccelerated when serializing reports. #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're currently seeing our services spend a large amount of time inside of the lightstep sdk serializing reports when they instrument themselves with tracing. This is in large part due to the fact that lightstep is using the pure python implemenation of Thrift. Fixes lightstep#89
added 4 commits
January 17, 2020 14:47
When using THttpClient.THttpClient as the transport, an invalid status code could cause memory usage to spike. This behaviour is corrected via TTransport.TBufferedTransport, so this check is no longer needed. Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently seeing our services spend a large amount of time inside of the lightstep sdk
serializing reports when they instrument themselves with tracing. This is in large part due to
the fact that lightstep is using the pure python implemenation of Thrift.
Fixes #89