Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #623

Merged
merged 7 commits into from
Aug 5, 2024
Merged

Refactor #623

merged 7 commits into from
Aug 5, 2024

Conversation

overcat
Copy link
Member

@overcat overcat commented Aug 2, 2024

No description provided.

… use `Asset.createNonNativeAsset(String, String)` or `Asset.createNativeAsset()` instead.
Copy link

codecov bot commented Aug 3, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.96%. Comparing base (c780543) to head (7c23a20).

Files Patch % Lines
src/main/java/org/stellar/sdk/Asset.java 50.00% 0 Missing and 1 partial ⚠️
src/main/java/org/stellar/sdk/TrustLineAsset.java 85.71% 0 Missing and 1 partial ⚠️
.../sdk/operations/LiquidityPoolDepositOperation.java 87.50% 0 Missing and 1 partial ⚠️
...sdk/operations/LiquidityPoolWithdrawOperation.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #623      +/-   ##
============================================
+ Coverage     77.77%   80.96%   +3.19%     
- Complexity     1078     1161      +83     
============================================
  Files           203      202       -1     
  Lines          4324     4335      +11     
  Branches        332      338       +6     
============================================
+ Hits           3363     3510     +147     
+ Misses          763      623     -140     
- Partials        198      202       +4     
Files Coverage Δ
...main/java/org/stellar/sdk/AbstractTransaction.java 75.00% <ø> (ø)
.../java/org/stellar/sdk/AssetTypeCreditAlphaNum.java 0.00% <ø> (ø)
...ava/org/stellar/sdk/AssetTypeCreditAlphaNum12.java 87.50% <ø> (ø)
...java/org/stellar/sdk/AssetTypeCreditAlphaNum4.java 88.46% <ø> (ø)
src/main/java/org/stellar/sdk/AssetTypeNative.java 71.42% <ø> (ø)
src/main/java/org/stellar/sdk/Auth.java 83.11% <ø> (ø)
.../main/java/org/stellar/sdk/FeeBumpTransaction.java 88.60% <ø> (ø)
src/main/java/org/stellar/sdk/KeyPair.java 88.54% <ø> (ø)
src/main/java/org/stellar/sdk/LedgerBounds.java 100.00% <100.00%> (+50.00%) ⬆️
src/main/java/org/stellar/sdk/LiquidityPool.java 80.64% <100.00%> (ø)
... and 22 more

... and 7 files with indirect coverage changes

@overcat overcat marked this pull request as ready for review August 5, 2024 07:47
@overcat overcat merged commit cae9e99 into master Aug 5, 2024
7 checks passed
@overcat overcat deleted the refactor branch August 7, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant