Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize fee calculation #618

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Commits on Jul 17, 2024

  1. refactor: optimize fee calculation

    - refactor: `TransactionBuilder#TransactionBuilder(Transaction)` has been removed, because the TransactionBuilder constructed from the transaction may be inconsistent with what the user expects.
    - fix: When calling `TransactionBuilder.build()`, the Soroban resource fee will be included in the `fee` of the built transaction.
    - fix: fix the issue where invoking `SorobanServer.prepareTransaction` for transactions that have already set `SorobanData` could result in unexpected high fees.
    overcat committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    b2d4523 View commit details
    Browse the repository at this point in the history