Update LedgerResponse and AccountResponse, remove outdated fields, and add missing fields.
#549
Conversation
There was a problem hiding this comment.
for consideration, add reference to https://developers.stellar.org/docs/fundamentals-and-concepts/stellar-data-structures/accounts to the AccountResponse class docs, noticed you added similar link for LedgerResponse , that content looks great!
Also, do you feel it's worthwhile to refactor AccountResponse to use lombok also, noticed you included that refactoring on pr for LedgerResponse, understand if not, as it's not related to the change scope.
There was a problem hiding this comment.
or consideration, add reference to https://developers.stellar.org/docs/fundamentals-and-concepts/stellar-data-structures/accounts to the AccountResponse class docs, noticed you added similar link for LedgerResponse , that content looks great!
Added.
Also, do you feel it's worthwhile to refactor AccountResponse to use lombok also, noticed you included that refactoring on pr for LedgerResponse, understand if not, as it's not related to the change scope.
I did not refactor AccountResponse using Lombok because it would cause breaking changes. I think I will have a separate PR later to use Lombok to rewrite all the code.
|
|
||
| @SerializedName("_links") | ||
| private final Links links; |
Closes #287, Closes #455