Fix the issue where the validity of the encoded strkey is not verified in certain scenarios. #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n certain scenarios.
overcat
changed the title
…n certain scenarios.
…n certain scenarios.
sreuland
reviewed
Sep 21, 2023
| @@ -23,7 +25,8 @@ class StrKey { | |||
|
|
|||
| public static final int ACCOUNT_ID_ADDRESS_LENGTH = 56; | |||
| private static final byte[] b32Table = decodingTable(); | |||
| private static final Base32 base32Codec = new Base32(); | |||
| private static final Base32 base32Codec = | |||
There was a problem hiding this comment.
this doesn't seem to be necessary to configure with additional settings and STRICT, since base32decode() determines validity now, and it may lead to partial duplication of functionality. I tried reverting this line locally, and the tests still pass.
sreuland
approved these changes
Sep 21, 2023
|
Hi @sreuland, can you check the status? I retriggered the CI, but it was still unable to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have replaced the base32 library, and their internal implementations are slightly different, which has caused a bug.
fix #540