Fix the issue of javadocJar not including documentation & Publish sourcesJar to the GitHub Release page.

[overcat]

• Fix the issue of javadocJar not including documentation.
• Publish sourcesJar to the GitHub Release page.

[sreuland]

subtle, thanks for including docs to explain this.

[overcat]

When I retriggered CI, Circle CI was still here, let me try to close this PR and create a new one.

[overcat]

HI @sreuland, please check my Discord message. Due to incorrect project configuration settings, we are unable to merge this PR at the moment.

[sreuland]

@overcat , we should be able to resolve this pr action check by tomorrow, will let you know when it's effective.

[sreuland]

@overcat , the action checks have been updated, 'android-test` needs to run still and then pr should allow merge

[overcat]

@sreuland, it seems that the settings are still incorrect. android-test should be changed to android-test (api ${{ matrix.emulator.api-level }})

[sreuland]

@overcat , I have submitted a change to only do pr action checks on build and test jobs, should land shortly.

[overcat]

@sreuland, I found the discussion initiated by leighmcculloch. If we want to add Android checks, we should add android-test (api 23) and android-test (api 32).

[sreuland]

@overcat , based on test values - https://github.com/overcat/java-stellar-sdk/blob/master/.github/workflows/test-deploy.yml#L78-L79

that would be android-test (api 26) and android-test (api 32) correct? I'm not sure if the target test dimension needs to be included as well, but can try this, or we just leave it to build and test for now to get pr's moving and try this later?

[sreuland]

@overcat, pr checks are resolved for now, based on build/test jobs.

[overcat]

@overcat , based on test values - https://github.com/overcat/java-stellar-sdk/blob/master/.github/workflows/test-deploy.yml#L78-L79

that would be android-test (api 26) and android-test (api 32) correct? I'm not sure if the target test dimension needs to be included as well, but can try this, or we just leave it to build and test for now to get pr's moving and try this later?

@sreuland, the reason why I hope it is android-test (api 23) instead of android-test (api 26) is because I set the target to 23 in #543, and I want to avoid modifying the GitHub settings again later. But now you have already set it as android-test (api 26), so I think we have to make another modification in the settings and set it as android-test (api 23).

[sreuland]

ok, let's wait for remaining work to converge back to master, and then we can try adding android-test (api <ver>) to the pr action checks, for now, as mentioned android test jobs are not required, just build/test