define cursor, order and limit in AssetsRequestBuilder object.

[overcat]

fix #371

Sorry for creating another PR like this, please see details at #519 (comment)

Let's ignore the CI failure caused by some unformatted code. We have resolved this issue in #521.

[sreuland]

can you add the new test case from the original pr #519 as well:

#519 (comment)

[overcat]

can you add the new test case from the original pr #519 as well:

#519 (comment)

There is already a relevant test in the original code, in the previous PR, I also kept this unchanged here.
https://github.com/stellar/java-stellar-sdk/blob/d9d0058ae4cb0adc20dc0a1e04e56bb2f7ec321d/src/test/java/org/stellar/sdk/requests/AssetsRequestBuilderTest.java#L12-L25

[sreuland]

There is already a relevant test in the original code, in the previous PR, I also kept this unchanged here.

ah, I see, this is because java has no receiver or self type available from abstract class methods, so, have to implement same methods on each concrete sub-class.

[sreuland]

@overcat , I was going to merge, but it looks like this is stuck waiting on circleci status, not sure when it clears up. it will be great once the soroban branch merges in with the fix to migrate off circleci to gh actions

[overcat]

@overcat , I was going to merge, but it looks like this is stuck waiting on circleci status, not sure when it clears up. it will be great once the soroban branch merges in with the fix to migrate off circleci to gh actions

As I mentioned above, this should be due to the unformatted code. If #521 is merged, it should solve this problem.

So let's first merge #521, but don't release it. Wait until we merge this PR and then release it together. This way I can try to re-trigger the CI.

[sreuland]

So let's first merge #521, but don't release it. Wait until we merge this PR and then release it together. This way I can try to re-trigger the CI.

@overcat, #521 has been merged, if you make a no-op commit onto this pr maybe it will release/reset the gha, and re-run again?

[overcat]

So let's first merge #521, but don't release it. Wait until we merge this PR and then release it together. This way I can try to re-trigger the CI.

@overcat, #521 has been merged, if you make a no-op commit onto this pr maybe it will release/reset the gha, and re-run again?

It turns green now.