Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code formatting tool. #480

Merged
merged 4 commits into from
Jul 12, 2023

Conversation

overcat
Copy link
Member

@overcat overcat commented Jul 8, 2023

This PR mainly adds a code formatting tool for better collaboration. The second commit formats the code. If you need to review the code, please check the changes in the first and third commits.

@overcat overcat changed the title Format code Add code formatting tool. Jul 8, 2023
Copy link
Contributor

@tamirms tamirms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think scripts/pre-commit.sh should be executable (e.g. run chmod +x scripts/pre-commit.sh). Otherwise, this PR looks good!

…code for changing file permissions on pre-commit hook.
@overcat
Copy link
Member Author

overcat commented Jul 11, 2023

I think scripts/pre-commit.sh should be executable (e.g. run chmod +x scripts/pre-commit.sh). Otherwise, this PR looks good!

Before, I had set the file as an executable in build.gradle. Now, I have already marked the original file as executable, see b838e16

@tamirms tamirms merged commit 0803b98 into lightsail-network:master Jul 12, 2023
@overcat overcat deleted the format-code branch July 13, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants