Skip to content

Commit

Permalink
refactor!: remove rateLimitLimit, rateLimitRemaining, and `rateLi…
Browse files Browse the repository at this point in the history
…mitReset` from the `Response`.
  • Loading branch information
overcat committed Jul 8, 2024
1 parent ffa074f commit 3d95603
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 45 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ As this project is pre 1.0, breaking changes may happen for minor version bumps.
- Removed some methods.
- Some field names have been changed to maintain consistency with the Horizon API.
- Removed all functions that return `Optional` value.
- refactor!: remove `rateLimitLimit`, `rateLimitRemaining`, and `rateLimitReset` from the `Response`.

## 0.44.0
### Update
Expand Down
3 changes: 0 additions & 3 deletions src/main/java/org/stellar/sdk/requests/ResponseHandler.java
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,6 @@ public T handleResponse(final Response response) {

if (response.code() >= 200 && response.code() < 300) {
T object = GsonSingleton.getInstance().fromJson(content, type.getType());
if (object instanceof org.stellar.sdk.responses.Response) {
((org.stellar.sdk.responses.Response) object).setHeaders(response.headers());
}
if (object instanceof TypedResponse) {
((TypedResponse<T>) object).setType(type);
}
Expand Down
42 changes: 0 additions & 42 deletions src/main/java/org/stellar/sdk/responses/Response.java
Original file line number Diff line number Diff line change
@@ -1,54 +1,12 @@
package org.stellar.sdk.responses;

import lombok.Getter;
import okhttp3.Headers;
import org.stellar.sdk.Asset;
import org.stellar.sdk.LiquidityPoolID;
import org.stellar.sdk.TrustLineAsset;

@Getter
public abstract class Response {
/**
* Returns X-RateLimit-Limit header from the response. This number represents the he maximum
* number of requests that the current client can make in one hour.
*
* @see <a href="https://developers.stellar.org/api/introduction/rate-limiting/"
* target="_blank">Rate Limiting</a>
*/
protected int rateLimitLimit;

/**
* Returns X-RateLimit-Remaining header from the response. The number of remaining requests for
* the current window.
*
* @see <a href="https://developers.stellar.org/api/introduction/rate-limiting/"
* target="_blank">Rate Limiting</a>
*/
protected int rateLimitRemaining;

/**
* Returns X-RateLimit-Reset header from the response. Seconds until a new window starts.
*
* @see <a href="https://developers.stellar.org/api/introduction/rate-limiting/"
* target="_blank">Rate Limiting</a>
*/
protected int rateLimitReset;

public void setHeaders(Headers headers) {
String limitHeader = headers.get("X-Ratelimit-Limit");
if (limitHeader != null) {
this.rateLimitLimit = Integer.parseInt(limitHeader);
}
String remainingHeader = headers.get("X-Ratelimit-Remaining");
if (remainingHeader != null) {
this.rateLimitRemaining = Integer.parseInt(remainingHeader);
}
String resetHeader = headers.get("X-Ratelimit-Reset");
if (resetHeader != null) {
this.rateLimitReset = Integer.parseInt(resetHeader);
}
}

protected static TrustLineAsset getTrustLineAsset(
String type, String code, String issuer, String liquidityPoolId) {
if ("liquidity_pool_shares".equals(type)) {
Expand Down

0 comments on commit 3d95603

Please sign in to comment.