feat: add warning interface on Nano devices. (#57)

release-notes.md

@@ -3,8 +3,7 @@
 ## v5.5.0
 
 ### Updated
-- Give an alert when enabling hash signing in settings. (Ledger Stax and Ledger Flex) 
-- Default to prohibit signing unverified contracts, need to enable "Custom contracts" in settings.
+- Optimize the signing process and add necessary alerts.
 - Add support for more Soroban tokens.
 - Bug fixes.
 

src/ui/bagl_hash.c

@@ -37,6 +37,8 @@
 #include "stellar/formatter.h"
 #include "stellar/printer.h"
 
+static void start_review_flow(void);
+
 static action_validate_cb g_validate_callback;
 
 // Validate/Invalidate transaction and go back to home
@@ -46,55 +48,135 @@ static void ui_action_validate_transaction(bool choice) {
 }
 
 // Step with icon and text
-UX_STEP_NOCB(ux_tx_hash_signing_review_step,
+UX_STEP_NOCB(ux_hash_signing_review_step,
              pnn,
              {
                  &C_icon_eye,
                  "Review",
                  "Hash Signing",
              });
-UX_STEP_NOCB(ux_tx_hash_signing_warning_step,
-             pbb,
-             {
-                 &C_icon_warning,
-                 "Dangerous",
-                 "Operation",
-             });
-UX_STEP_NOCB(ux_tx_hash_signing_display_hash_step,
+UX_STEP_NOCB(ux_hash_signing_display_hash_step,
              bnnn_paging,
              {
                  .title = "Hash",
                  .text = G.ui.detail_value,
              });
 // Step with approve button
-UX_STEP_CB(ux_tx_hash_display_approve_step,
+UX_STEP_CB(ux_hash_display_approve_step,
            pb,
            (*g_validate_callback)(true),
            {
                &C_icon_validate_14,
                "Sign Hash",
            });
 // Step with reject button
-UX_STEP_CB(ux_tx_hash_display_reject_step,
+UX_STEP_CB(ux_hash_display_reject_step,
            pb,
            (*g_validate_callback)(false),
            {
                &C_icon_crossmark,
                "Reject",
            });
 
+UX_STEP_NOCB(ux_hash_approval_blind_signing_reminder_step,
+             pbb,
+             {
+                 &C_icon_warning,
+                 "You accepted",
+                 "the risks",
+             });
+
 // FLOW to display hash signing
 // #1 screen: eye icon + "Review Transaction"
-// #2 screen: warning icon + "Hash Signing"
-// #3 screen: display hash
+// #2 screen: display hash
+// #3 screen: display warning
 // #4 screen: approve button
 // #5 screen: reject button
-UX_FLOW(ux_tx_hash_signing_flow,
-        &ux_tx_hash_signing_review_step,
-        &ux_tx_hash_signing_warning_step,
-        &ux_tx_hash_signing_display_hash_step,
-        &ux_tx_hash_display_approve_step,
-        &ux_tx_hash_display_reject_step);
+UX_FLOW(ux_hash_signing_flow,
+        &ux_hash_signing_review_step,
+        &ux_hash_signing_display_hash_step,
+        &ux_hash_approval_blind_signing_reminder_step,
+        &ux_hash_display_approve_step,
+        &ux_hash_display_reject_step);
+
+// clang-format off
+UX_STEP_NOCB(
+    ux_hash_blind_signing_warning_step,
+    pbb,
+    {
+      &C_icon_warning,
+#ifdef TARGET_NANOS
+      "Transaction",
+      "not trusted",
+#else
+      "This transaction",
+      "cannot be trusted",
+#endif
+    });
+#ifndef TARGET_NANOS
+UX_STEP_NOCB(
+    ux_hash_blind_signing_text1_step,
+    nnnn,
+    {
+      "Your Ledger cannot",
+      "decode this",
+      "transaction. If you",
+      "sign it, you could",
+    });
+UX_STEP_NOCB(
+    ux_hash_blind_signing_text2_step,
+    nnnn,
+    {
+      "be authorizing",
+      "malicious actions",
+      "that can drain your",
+      "wallet.",
+    });
+#endif
+UX_STEP_NOCB(
+    ux_hash_blind_signing_link_step,
+    nn,
+    {
+      "Learn more:",
+      "ledger.com/e8",
+    });
+UX_STEP_CB(
+    ux_hash_blind_signing_accept_step,
+    pbb,
+    start_review_flow(),
+    {
+      &C_icon_validate_14,
+#ifdef TARGET_NANOS
+      "Accept risk",
+      "and review",
+#else
+      "Accept risk and",
+      "review transaction",
+#endif
+    });
+UX_STEP_CB(
+    ux_hash_blind_signing_reject_step,
+    pb,
+    ui_action_validate_transaction(false),
+    {
+      &C_icon_crossmark,
+      "Reject",
+    });
+// clang-format on
+
+UX_FLOW(ux_hash_blind_signing_flow,
+        &ux_hash_blind_signing_warning_step,
+#ifndef TARGET_NANOS
+        &ux_hash_blind_signing_text1_step,
+        &ux_hash_blind_signing_text2_step,
+#endif
+        &ux_hash_blind_signing_link_step,
+        &ux_hash_blind_signing_accept_step,
+        &ux_hash_blind_signing_reject_step);
+
+static void start_review_flow() {
+    ux_flow_init(0, ux_hash_signing_flow, NULL);
+}
 
 int ui_display_hash() {
     if (G_context.req_type != CONFIRM_HASH || G_context.state != STATE_NONE) {
@@ -110,7 +192,8 @@ int ui_display_hash() {
 
     g_validate_callback = &ui_action_validate_transaction;
 
-    ux_flow_init(0, ux_tx_hash_signing_flow, NULL);
+    ux_flow_init(0, ux_hash_blind_signing_flow, NULL);
+
     return 0;
 }
 #endif

src/ui/bagl_transaction.c

@@ -39,6 +39,8 @@
 #include "stellar/formatter.h"
 #include "stellar/printer.h"
 
+static void start_review_flow(void);
+
 static action_validate_cb g_validate_callback;
 static bool data_exists;
 static formatter_data_t formatter_data;
@@ -187,6 +189,13 @@ UX_STEP_CB(ux_tx_reject_step,
                "Reject",
            });
 
+UX_STEP_NOCB(ux_transaction_approval_blind_signing_reminder_step,
+             pbb,
+             {
+                 &C_icon_warning,
+                 "You accepted",
+                 "the risks",
+             });
 // FLOW to display transaction information:
 // https://developers.ledger.com/docs/device-app/develop/ui/flows/advanced-display-management
 UX_FLOW(ux_tx_flow,
@@ -205,6 +214,107 @@ UX_FLOW(ux_auth_flow,
         &ux_auth_approve_step,
         &ux_tx_reject_step);
 
+UX_FLOW(ux_tx_flow_with_reminder,
+        &ux_tx_review_step,
+        &ux_tx_upper_delimiter,
+        &ux_tx_generic,
+        &ux_tx_lower_delimiter,
+        &ux_transaction_approval_blind_signing_reminder_step,
+        &ux_tx_approve_step,
+        &ux_tx_reject_step);
+
+UX_FLOW(ux_auth_flow_with_reminder,
+        &ux_auth_review_step,
+        &ux_tx_upper_delimiter,
+        &ux_tx_generic,
+        &ux_tx_lower_delimiter,
+        &ux_transaction_approval_blind_signing_reminder_step,
+        &ux_auth_approve_step,
+        &ux_tx_reject_step);
+
+// clang-format off
+UX_STEP_NOCB(
+    ux_transaction_blind_signing_warning_step,
+    pbb,
+    {
+      &C_icon_warning,
+#ifdef TARGET_NANOS
+      "Transaction",
+      "not trusted",
+#else
+      "This transaction",
+      "cannot be trusted",
+#endif
+    });
+#ifndef TARGET_NANOS
+UX_STEP_NOCB(
+    ux_transaction_blind_signing_text1_step,
+    nnnn,
+    {
+      "Your Ledger cannot",
+      "decode this",
+      "transaction. If you",
+      "sign it, you could",
+    });
+UX_STEP_NOCB(
+    ux_transaction_blind_signing_text2_step,
+    nnnn,
+    {
+      "be authorizing",
+      "malicious actions",
+      "that can drain your",
+      "wallet.",
+    });
+#endif
+UX_STEP_NOCB(
+    ux_transaction_blind_signing_link_step,
+    nn,
+    {
+      "Learn more:",
+      "ledger.com/e8",
+    });
+UX_STEP_CB(
+    ux_transaction_blind_signing_accept_step,
+    pbb,
+    start_review_flow(),
+    {
+      &C_icon_validate_14,
+#ifdef TARGET_NANOS
+      "Accept risk",
+      "and review",
+#else
+      "Accept risk and",
+      "review transaction",
+#endif
+    });
+UX_STEP_CB(
+    ux_transaction_blind_signing_reject_step,
+    pb,
+    ui_action_validate_transaction(false),
+    {
+      &C_icon_crossmark,
+      "Reject",
+    });
+// clang-format on
+
+UX_FLOW(ux_transaction_blind_signing_flow,
+        &ux_transaction_blind_signing_warning_step,
+#ifndef TARGET_NANOS
+        &ux_transaction_blind_signing_text1_step,
+        &ux_transaction_blind_signing_text2_step,
+#endif
+        &ux_transaction_blind_signing_link_step,
+        &ux_transaction_blind_signing_accept_step,
+        &ux_transaction_blind_signing_reject_step);
+
+static void start_review_flow() {
+    if (G_context.req_type == CONFIRM_TRANSACTION) {
+        ux_flow_init(0, ux_tx_flow_with_reminder, NULL);
+    } else {
+        ux_flow_init(0, ux_auth_flow_with_reminder, NULL);
+    }
+}
+
 void prepare_display() {
     formatter_data_t fdata = {
         .raw_data = G_context.raw,
@@ -236,7 +346,11 @@ int ui_display_transaction() {
         return io_send_sw(SW_BAD_STATE);
     }
     prepare_display();
-    ux_flow_init(0, ux_tx_flow, NULL);
+    if (G_context.unverified_contracts) {
+        ux_flow_init(0, ux_transaction_blind_signing_flow, NULL);
+    } else {
+        ux_flow_init(0, ux_tx_flow, NULL);
+    }
     return 0;
 }
 
@@ -246,7 +360,11 @@ int ui_display_auth() {
         return io_send_sw(SW_BAD_STATE);
     }
     prepare_display();
-    ux_flow_init(0, ux_auth_flow, NULL);
+    if (G_context.unverified_contracts) {
+        ux_flow_init(0, ux_transaction_blind_signing_flow, NULL);
+    } else {
+        ux_flow_init(0, ux_auth_flow, NULL);
+    }
     return 0;
 }
 #endif