Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collectors: do not init htlc monitor when htlc monitoring is disabled #106

Merged
merged 1 commit into from
Feb 7, 2024
Merged

collectors: do not init htlc monitor when htlc monitoring is disabled #106

merged 1 commit into from
Feb 7, 2024

Conversation

mrfelton
Copy link
Contributor

@mrfelton mrfelton commented Feb 6, 2024

Prevents htlc stream from being initialised when it isn't needed

Fix for #103

guggero
guggero requested changes Feb 6, 2024
View reviewed changes
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Though this will probably crash immediately (see inline comment).

collectors/prometheus.go Outdated Show resolved Hide resolved
@mrfelton mrfelton force-pushed the disable-htlc-stream branch 2 times, most recently from 9164283 to bd9b085 Compare February 6, 2024 21:48
@mrfelton mrfelton requested a review from guggero February 6, 2024 22:03
guggero
guggero approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 🎉

@guggero guggero requested a review from bhandras February 7, 2024 09:08
bhandras
bhandras approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guggero guggero merged commit 02ee7ca into lightninglabs:master Feb 7, 2024
1 check passed
@mrfelton mrfelton mentioned this pull request Feb 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhandras bhandras bhandras approved these changes

@guggero guggero guggero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrfelton @bhandras @guggero