lndmon: cache closedChannels response #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
requested changes
Jan 25, 2024
bhandras
reviewed
Jan 26, 2024
djkazic
force-pushed
the
feature/cached-grpc-responses
branch
from
d52b3b7
to
7c5b272
Compare
|
Squashed && force pushed @bhandras |
bhandras
reviewed
Jan 26, 2024
bhandras
reviewed
Jan 26, 2024
bhandras
reviewed
Jan 26, 2024
djkazic
force-pushed
the
feature/cached-grpc-responses
branch
from
7c5b272
to
33fe8a3
Compare
|
Amended && force pushed @bhandras |
bhandras
reviewed
Jan 26, 2024
djkazic
force-pushed
the
feature/cached-grpc-responses
branch
from
33fe8a3
to
47a7fc5
Compare
|
Fixed quitChan setting @bhandras |
bhandras
approved these changes
Jan 26, 2024
djkazic
force-pushed
the
feature/cached-grpc-responses
branch
from
47a7fc5
to
7ec821a
Compare
|
Addressed nits @bhandras |
|
Deploying to testnet today. |
guggero
reviewed
Jan 30, 2024
collectors/channels_collector.go
Outdated
|
|
||
| // Start a ticker to update the cache once per 10m | ||
| go func() { | ||
| ticker := time.NewTicker(10 * time.Minute) |
There was a problem hiding this comment.
Should we make this a package-level variable just so "magic numbers" are easier to find and change?
There was a problem hiding this comment.
The 10 minute magic number is still here in the latest push.
djkazic
force-pushed
the
feature/cached-grpc-responses
branch
from
7ec821a
to
48670c8
Compare
|
Addressed nits @guggero |
guggero
reviewed
Jan 31, 2024
collectors/channels_collector.go
Outdated
|
|
||
| // Start a ticker to update the cache once per 10m | ||
| go func() { | ||
| ticker := time.NewTicker(10 * time.Minute) |
There was a problem hiding this comment.
The 10 minute magic number is still here in the latest push.
djkazic
force-pushed
the
feature/cached-grpc-responses
branch
from
48670c8
to
0a31bae
Compare
|
Did another pass @guggero |
djkazic
force-pushed
the
feature/cached-grpc-responses
branch
from
0a31bae
to
c8e69f9
Compare
guggero
reviewed
Jan 31, 2024
djkazic
force-pushed
the
feature/cached-grpc-responses
branch
from
c8e69f9
to
662470e
Compare
|
May also want to also cache |
bitodt
added a commit
to bitodt/lndmon
that referenced
this pull request
Feb 4, 2024
…d-grpc-responses lndmon: cache closedChannels response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we call closedChannels once per scrape, this can be fairly expensive for LND's grpcServer. This PR will add:
closedChannelsclosedChannelsGRPC endpoint