[WIP] New ChannelId enum #2451
Closed
[WIP] New ChannelId enum #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2451 +/- ##
=======================================
Coverage 90.33% 90.33%
=======================================
Files 106 106
Lines 55732 55792 +60
Branches 55732 55792 +60
=======================================
+ Hits 50347 50402 +55
- Misses 5385 5390 +5
☔ View full report in Codecov by Sentry. |
tnull
reviewed
Jul 26, 2023
| @@ -627,7 +627,7 @@ where | |||
| log_trace!(logger, "Considering {} channels for invoice route hints", channels.len()); | |||
| for channel in channels.into_iter().filter(|chan| chan.is_channel_ready) { | |||
| if channel.get_inbound_payment_scid().is_none() || channel.counterparty.forwarding_info.is_none() { | |||
| log_trace!(logger, "Ignoring channel {} for invoice route hints", log_bytes!(channel.channel_id)); | |||
| log_trace!(logger, "Ignoring channel {} for invoice route hints", log_bytes!(channel.channel_id.bytes()[..])); | |||
There was a problem hiding this comment.
Since we're already touching it it would be nice to implement Display/Debug for ChannelId and log in a more readable form, e.g., as a hex string.
There was a problem hiding this comment.
I've just done this (in #2485), and I've seen this comment only now :)
|
One fuzz test fails, to check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2408 . Introduces a new
ChannelIdenum, with two variants, for normal funding-tx-based and temporary ID, both wrapper around 32-byte data.TODO:
FundingTxBased)