#584 Add root config origin to exception #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Ensirius, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
havocp
approved these changes
Sep 7, 2018
| @@ -153,7 +153,7 @@ static private AbstractConfigValue findKeyOrNull(AbstractConfigObject self, Stri | |||
| ConfigValueType expected, Path originalPath) { | |||
| AbstractConfigValue v = self.peekAssumingResolved(key, originalPath); | |||
| if (v == null) | |||
| throw new ConfigException.Missing(originalPath.render()); | |||
| throw new ConfigException.Missing(self.origin(), originalPath); | |||
There was a problem hiding this comment.
I think I'd rather keep the Path.render() here instead of making Path public. Otherwise the PR lgtm, thanks!
There was a problem hiding this comment.
I used Path as argument because constructor with string argument ar used in Null exception
|
CI needs to pass, though. probably there's a test failing? |
|
I got confused with constructors but i think I solved it now |
|
I have signed CLA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will improve config debuging process adding the root config line number