Changes in acoustic_indices.py #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using the functions from scikit-maad
…so dependencies are fixed and checks pass
…mpute_ndsi because it has to be tuples in order to use the function from scikit-maad
…ute_zcr, and now s has to be an ndarray which represents the signal and not an object from the class Signal
…e_zcr which is using function from maad
…inear units to use these functions
…signal.py in order to match with the changes done in acoustic_indices.py
…c_indices.py which was wrong due to multiple outputs from the function soundscape_index from scikit
… method _apply_multiple in acoustic_file.py in order to avoid errors with arithmetical operations
…m the class Signal
… from the Signal class
…re consistent. Fixes lifewatch#11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the functions in acoustic_indices.py using functions from the scikit-maad package and added a new test files for these functions.