Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: public asset path go-to definition #382

Draft
wants to merge 1 commit into
base: component-context-info-origin
Choose a base branch
from

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Apr 25, 2022

Adds ability to go to public asset by it's path.

Not landing it, because it's unable to show original file (image), once clicked
VSCode does not support binary documents in go-to definition requests resolution

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #382 (7add72b) into component-context-info-origin (5f3e91d) will increase coverage by 0.01%.
The diff coverage is 92.85%.

❗ Current head 7add72b differs from pull request most recent head 0b9d932. Consider uploading reports for the commit 0b9d932 to get more accurate results

@@                        Coverage Diff                        @@
##           component-context-info-origin     #382      +/-   ##
=================================================================
+ Coverage                          72.40%   72.42%   +0.01%     
=================================================================
  Files                                 57       57              
  Lines                               4871     4895      +24     
  Branches                             946      955       +9     
=================================================================
+ Hits                                3527     3545      +18     
- Misses                              1344     1350       +6     
Impacted Files Coverage Δ
src/utils/usages-api.ts 56.57% <50.00%> (ø)
src/glimmer-utils.ts 52.50% <92.30%> (+2.50%) ⬆️
...uiltin-addons/core/template-completion-provider.ts 93.02% <100.00%> (ø)
...uiltin-addons/core/template-definition-provider.ts 77.73% <100.00%> (+1.09%) ⬆️
src/utils/yield-context-extractor.ts 55.20% <0.00%> (-4.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 253e5a6...0b9d932. Read the comment docs.

feat: path go-to definition

test
@lifeart lifeart force-pushed the string-path-definition-provider branch from 7add72b to 0b9d932 Compare April 25, 2022 05:53
@lifeart lifeart marked this pull request as draft April 25, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant