Stop using random-numgen, not needed in recent OpenWrt #1117
Conversation
| @@ -6,5 +6,5 @@ unique_append() | |||
| } | |||
|
|
|||
| unique_append \ | |||
| '*/20 * * * * ((sleep $(($(random-numgen) % 600)); check-date-http &> /dev/null)&)'\ | |||
| '*/20 * * * * ((sleep $(($RANDOM % 600)); check-date-http &> /dev/null)&)'\ | |||
There was a problem hiding this comment.
@ilario are you sure the $ is needed before RANDOM in this context? AFAIR inside $(()) arithmetic evaluation the plain variable name without $ should work, or it is like that only in bash ?
There was a problem hiding this comment.
same question goes for all other similar occurrencies
There was a problem hiding this comment.
Just checked on a virtualized image of LibreMesh 2024.1-rc1 and you remember right, it works also without the $.
Removing it is not going to make the code any better, but ok I am going to remove it from everywhere.
There was a problem hiding this comment.
well less non useful chars to read makes it more readable IMHO, plus it uses a bit less bytes ;-)
|
@G10h4ck pls check if the changes are ok |
|
Great. Thanks! |
|
Picked to branch 2024.1 https://github.com/libremesh/lime-packages/tree/2024.1 |
The random-numgen package was created in #991 as in OpenWrt 21 BusyBox did not have $RANDOM enabled by default (so it was not present in the official ImageBuilder), see #800.
But since OpenWrt 22 it is present by default, see openwrt/packages#20728 so there is no need to use it.
Maybe we can keep the random-numgen package for a few more years and then delete it.
This commit should be picked also in the 2024.1 branch.
Fix #1075