Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shared-state-async network statistics sharing #1087

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

G10h4ck
Copy link
Member

@G10h4ck G10h4ck commented Feb 22, 2024

No description provided.

@G10h4ck G10h4ck added this to the mesh-wide milestone Feb 22, 2024
@ilario
Copy link
Member

ilario commented Feb 24, 2024 via email

@G10h4ck
Copy link
Member Author

G10h4ck commented Feb 24, 2024

This stuff (and in general what is meant for mesh-wide milestone) is developed on top (and depends) on OpenWrt development branch, as an example shared-state-async depends on a GCC version which is not shipped yet in OpenWrt stable releases, otherwise it will not compile properly.
So doing the change you suggests hoping for retro-compatibility would be futile.

@G10h4ck
Copy link
Member Author

G10h4ck commented Feb 24, 2024

other even more retro-compatibility breaking stuff is coming to out of my experimentation to have better support for newer radios https://www.youtube.com/live/DOH5FBMTXmE?feature=shared&t=10848

@ilario
Copy link
Member

ilario commented Feb 26, 2024

Ok, will it work at least on OpenWrt 23?
If not, please do not propose those changes on the master branch, which is being used for preparing a release based on OpenWrt 23 (we could also create a branch for the release...).

@G10h4ck
Copy link
Member Author

G10h4ck commented Feb 26, 2024

AFAIU it will not work on OpenWrt 23 either, @javierbrk tried to compile and failed because of not enough recent compiler AFAIR

Better creating a branch for the planned release and backport there stuff if needed, while development keep staying on master branch

@ilario
Copy link
Member

ilario commented Feb 26, 2024

Ok, please create a branch with the code you know will work with OpenWrt 23.

@G10h4ck
Copy link
Member Author

G10h4ck commented Feb 26, 2024

Ain't got time for that last compatible commit should be this a5eb7d8

@pony1k
Copy link
Contributor

pony1k commented Feb 26, 2024

AFAIU it will not work on OpenWrt 23 either, @javierbrk tried to compile and failed because of not enough recent compiler AFAIR

I compiled shared-state-async from a823f47 for OpenWrt 23.05.2 and it is working.

@javierbrk
Copy link
Collaborator

javierbrk commented Feb 26, 2024 via email

@G10h4ck
Copy link
Member Author

G10h4ck commented Feb 26, 2024

Good news! So we can go ahead without dealing with multiple branches for now

@G10h4ck G10h4ck merged commit 6992335 into libremesh:master Feb 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants