Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set high metric on anygw prefix route #1079

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

pony1k
Copy link
Contributor

@pony1k pony1k commented Feb 8, 2024

Make sure anygw is not used for communication with hosts in the same network.
Fixes #1078

@ilario
Copy link
Member

ilario commented Feb 8, 2024

It looks great to me.
Is the extra comma here metric = '2147483647', not causing any error?

@G10h4ck
Copy link
Member

G10h4ck commented Feb 8, 2024

looks great to me, please remove the extra comma ;)

Make sure anygw is not used for communication with hosts in the same
network.
Fixes libremesh#1078
@pony1k
Copy link
Contributor Author

pony1k commented Feb 8, 2024

No, the extra comma did not cause any error. Anyway, I removed the extra comma. Yes, I have tested it.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e322985) 79.56% compared to head (43780f2) 79.54%.

❗ Current head 43780f2 differs from pull request most recent head 88fe702. Consider uploading reports for the commit 88fe702 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1079      +/-   ##
==========================================
- Coverage   79.56%   79.54%   -0.03%     
==========================================
  Files          53       53              
  Lines        4561     4561              
==========================================
- Hits         3629     3628       -1     
- Misses        932      933       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ilario ilario merged commit 0c8a915 into libremesh:master Feb 8, 2024
1 check passed
@ilario
Copy link
Member

ilario commented Feb 8, 2024

Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

anygw routing issue
4 participants