Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use ts in examples, ensure package docs are up to date #2323

Merged
merged 1 commit into from
Dec 18, 2023
Merged

docs: use ts in examples, ensure package docs are up to date #2323

merged 1 commit into from
Dec 18, 2023

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Dec 18, 2023 •
edited by maschad
Loading

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Closes #1777

@achingbrain achingbrain requested a review from a team as a code owner December 18, 2023 17:52
maschad
maschad requested changes Dec 18, 2023
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should wait until doc-check is re-enabled in #2250 before merging this to ensure they are up to date.

@achingbrain
Copy link
Member Author

AFAIK #2250 is blocked on TypeStrong/ts-node#2076 making it into a release so let's not wait for that here.

@achingbrain achingbrain merged commit 07f3afe into main Dec 18, 2023
23 checks passed
@achingbrain achingbrain deleted the docs/align-docs branch December 18, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maschad maschad maschad requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Convert Configuration examples in docs to Typescript
2 participants
@achingbrain @maschad