Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Dropwizard 4 #136

Merged
merged 29 commits into from
Dec 18, 2023
Merged

Update to Dropwizard 4 #136

merged 29 commits into from
Dec 18, 2023

Conversation

lfoppiano
Copy link
Owner

@lfoppiano lfoppiano commented May 23, 2022 •
edited
Loading

This PR will update grobid-quantities to Dropwizard 2.x 4.x

@coveralls
Copy link

coveralls commented May 24, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.005%) to 27.675% when pulling e95b763 on feature/dropwizard2 into 57714d5 on master.

@lfoppiano
Copy link
Owner Author

Due to dropwizard/dropwizard#5318 and dropwizard/dropwizard#5268 I will postpone the upgrade.

@lfoppiano lfoppiano mentioned this pull request Jun 15, 2023
Open
@lfoppiano lfoppiano changed the title Update to Dropwizard 2 Update to Dropwizard 4 Jun 16, 2023
@lfoppiano lfoppiano marked this pull request as ready for review December 15, 2023 01:47
@coveralls
Copy link

coveralls commented Dec 15, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7243446769

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 208 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.3%) to 25.051%
Files with Coverage Reduction New Missed Lines %
org/grobid/service/controller/HealthCheck.java 3 0.0%
org/grobid/service/main/GrobidQuantitiesApplication.java 10 0.0%
org/grobid/service/command/UnitBatchProcessingCommand.java 11 0.0%
org/grobid/service/command/TrainingGenerationCommand.java 18 0.0%
org/grobid/core/engines/QuantityParser.java 166 0.0%
Totals Coverage Status
Change from base Build 7218026571: -0.3%
Covered Lines: 1702
Relevant Lines: 6303
💛 - Coveralls

@lfoppiano lfoppiano merged commit 4a1487c into master Dec 18, 2023
4 checks passed
@lfoppiano lfoppiano deleted the feature/dropwizard2 branch December 18, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lfoppiano @coveralls