Handle corrupt files #236
Merged
Handle corrupt files #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
letmaik
requested changes
Sep 7, 2024
mplough-kobold
force-pushed
the
matt-handle-corrupt-files
branch
from
2da4003
to
468cc91
Compare
mplough-kobold
force-pushed
the
matt-handle-corrupt-files
branch
from
468cc91
to
fbe619d
Compare
letmaik
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, #76 attempted to handle corruption by setting up a libraw
dataerror_handler. #229 refined #76 but there are segfaults.This PR handles corruption in a different way: We ask libraw how many data errors occurred when reading the file and raise an exception if there were more than zero. The test data from #229 was particularly useful in verifying that the method works.
Fixes #228.