Raise version requirement of soft dependency to local_recompletion du…

…e to fixed bugs there

CHANGES.md

@@ -4,6 +4,10 @@ moodle-enrol_semco
 Changes
 -------
 
+### Unreleased
+
+* 2024-07-18 - Raise version requirement of soft dependency to local_recompletion due to fixed bugs there.
+
 ### v4.2-r5
 
 * 2024-06-01 - Bugfix: Remove debug warning in enrol_semco_enrol_user webservice endpoint.

README.md

@@ -35,7 +35,7 @@ Soft dependencies
 The SEMCO enrolment plugin is able to reset a user's course completion if he gets enrolled into a particular course by SEMCO once more.
 To realize this course completion reset and to avoid to re-invent the wheel, this plugin has a soft dependency to local_recompletion (see https://moodle.org/plugins/local_recompletion) by Dan Marsden.
 
-Please install local_recompletion with at least version 2023111402 alongside this plugin if you plan to use subsequent user enrolments into the same course and need to reset course completion.
+Please install local_recompletion with at least version 2023112707 alongside this plugin if you plan to use subsequent user enrolments into the same course and need to reset course completion.
 If you do not need plan to reset course completion, you do not need to install local_recompletion.
 
 
@@ -223,7 +223,7 @@ Useful settings for local_recompletion
 
 If you decide to use the companion plugin local_recompletion to allow SEMCO to reset course completions during subsequent user enrolments, please verify these settings of local_recompletion before the go-live of your integration:
 
-* SEMCO can only reset a user's course completion if the "Recompletion type" setting in the particular course is set to "On demand". To avoid hickups with courses where the teacher forgot to set the proper "Recompletion type" in his course, you should set the default recompletion type on /admin/settings.php?section=local_recompletion to "On demand" as well.
+* SEMCO can only reset a user's course completion if the "Recompletion type" setting in the particular course is set to "On demand". It's up to the individual teachers to go to the course recompletion settings in their courses and save the settings before SEMCO can reset a user's course completion in a course.
 * By design, SEMCO will reset a user's course completion even on the user's first SEMCO enrolment into the course. This might seem unnecessary, but as it is not impossible that the user might have been manually enrolled before into that course (and might have completed it then), SEMCO resets the course completion just to be sure that the course is clean before each and every SEMCO enrolment. Against this background, the standard behaviour of local_recompletion to send out a notification message to the user when the course is reset will confuse the user. To avoid such confusion, you should disable the "Send recompletion message" setting on /admin/settings.php?section=local_recompletion.
 * By default, local_recompletion is configured in a way that it does not reset any activity in a course unless the teacher activates the activity type's reset in his particular course. To ease the teacher's life and to avoid that SEMCO triggers a course completion reset but nothing is deleted from the course in the end, you should enable all items in the "Plugins settings" section on /admin/settings.php?section=local_recompletion which are relevant for the courses in your Moodle instance.
 

lang/en/enrol_semco.php

@@ -37,8 +37,8 @@
 $string['settings_coursecompletionheading'] = 'Course completion';
 $string['settings_coursecompletionlrcintro'] = '<p>The SEMCO enrolment plugin is able to reset a user\'s course completion if he gets enrolled into a particular course by SEMCO once more.<br />
 To realize this course completion reset and to avoid to re-invent the wheel, this plugin has a soft dependency to <a href="https://moodle.org/plugins/local_recompletion">local_recompletion</a> by Dan Marsden.</p>';
-$string['settings_coursecompletionlrcfound'] = '<p>The plugin local_recompletion is installed with at least version 2023111402. You are able to use subsequent user enrolments into the same course and to reset course completion.</p>';
-$string['settings_coursecompletionlrcnotfound'] = '<p>Please install local_recompletion with at least version 2023111402 alongside this plugin if you plan to use subsequent user enrolments into the same course and need to reset course completion.<br />
+$string['settings_coursecompletionlrcfound'] = '<p>The plugin local_recompletion is installed with at least version 2023112707. You are able to use subsequent user enrolments into the same course and to reset course completion.</p>';
+$string['settings_coursecompletionlrcnotfound'] = '<p>Please install local_recompletion with at least version 2023112707 alongside this plugin if you plan to use subsequent user enrolments into the same course and need to reset course completion.<br />
 If you do not need plan to reset course completion, you do not need to install local_recompletion.</p>';
 $string['settings_coursecompletionnote'] = '<p>Please note: SEMCO just triggers the on-demand course recompletion which is provided by the <a href="{$a}">course recompletion plugin</a>. It\'s still up to the individual teachers to configure course recompletion in their courses according to the individual needs and to set the course\'s recompletion type to \'On demand\'.</p>';
 $string['settings_enrolmentheading'] = 'Enrolment process';

locallib.php

@@ -240,7 +240,7 @@ function enrol_semco_check_local_recompletion() {
             $pluginversion = core_plugin_manager::instance()->get_plugin_info('local_recompletion')->versiondb;
 
             // If the version is high enough.
-            if ($pluginversion >= 2023111402) {
+            if ($pluginversion >= 2023112707) {
                 // Remember the check result.
                 $localrecompletioninstalled = true;