Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spd window #315

Open
wants to merge 59 commits into
base: dev
Choose a base branch
from
Open

Spd window #315

wants to merge 59 commits into from

Conversation

flinkeKoralle
Copy link

@flinkeKoralle flinkeKoralle commented Feb 5, 2024

Speed Window Preselection Function

Description of Changes

When in managed speed, rotating the speed selector knob will open the window for a certain time.
If this speed is pulled, than speed becomes selected, otherwise it returns to managed.
Also there is a difference between an open window with active managed speed (yellow dot) and just a closed window (dahes).
Furthermore selected speed is inhibited on ground, once engines are running.

Screenshots (optional)

Bugs fixed (if any)

FCU speed window
FCU altitude selection of 100/1000

Checklist:

  • [x ] My changes follow the Contributing Guidelines.
  • [x ] My changes implement realistic features.
  • Please have a main Developer test my changes before merging.

ready for merge

Maximiliano Keller added 23 commits December 20, 2023 13:58
todo: spd adjust in managed gets fmgc speed instead of current
todo: fcu default spd is 0. should be 100.
todo: if FD1+2 off then revert to selected speed
todo: implement close/open spd window in FCU.nas file, simplifying the a320.flightdeck.xml file
todo: remove custom.input.spdManaged -> not needed
managed speed stops by itself if not valid
todo: check when fcu-spd is reset to selected
todo: display correctly on fcu
show dashes and no dot when in done phase
todo: phase transition check (done phase)
and redundant variables
TODO: mng spd triggered by to/mct
TODO: selected spd only after 5s airborne
TODO: sel spd disarms on gnd at eng start
sel spd not poss. on gnd with engs running and fd on.
TODO: spd push on gnd, if pos lost no mangd spd
TODO: move Mach/Speed changeover to a property and activate via listener.
@Octal450
Copy link
Collaborator

Octal450 commented Feb 5, 2024

That's a lot of changes, will need thorough testing.

I can't promise a timeline on that right now but I'll add it to my list.

Kind Regards,
Josh

@flinkeKoralle
Copy link
Author

flinkeKoralle commented Feb 7, 2024 via email

@Octal450 Octal450 self-assigned this Sep 29, 2024
@Octal450 Octal450 added the Component: FMGC FMGC or MCDU related label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: FMGC FMGC or MCDU related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants