Adopt makem.sh for build support (linting, running tests) #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Discovered some issues on macos, opening alphapapa/makem.sh#49 |
Also use makem.sh's support for checkdoc, since the previously-used checkdoc-batch URL is broken.
Currently, we need the --compile-batch option because compiling the files individually fails on Emacs 25 (I think due to subr-x macros not being loaded at startup).
We just sprinkle some eval-when-compiles around for older Emacs. We can remove them when the CI no longer supports Emacs 25.1.
|
Updated makem.sh to include the macOS fix. |
|
I'd be generally in favour of this, because I'm not sure if any of the more active maintainers have any specific love for cmake, and it would be good to include more linting etc. in the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches from CMake and custom make rules to using
makem.sh, as suggested in #423.
It also includes a small tweak to just disable#431 was merged, so that change was removed upon rebase.ledger-mode/test-001(whichrequires running Emacs interactively) when makem.sh runs tests, since it does
not provide a custom ERT selector. That change can be removed once #431 is
merged.
Fix #423.