Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a pixi file and split into two envs (host & build) #2744

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

wolfv
Copy link
Contributor

@wolfv wolfv commented Jun 22, 2024

I was trying to do some development on lpython.

It might simplify the first steps for some people :) The lockfile should create a consistent environment. I only have tested this on macOS arm64 so far though.

We create two environments:

  • compiler: contains cmake, ninja, and the C++ compiler
  • host: contains llvmdev and zlib (and whatever else might be linked)

A start task is also added to run the development version of lpython. I was pretty confused for a while which runtime folder to include so I also added that to the start command (and changed build1.sh).

I can fix this up for linux and windows if you all like it.

Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove pixi.lock for now, because it's huge and will get even bigger for all platforms. This can always be added later.

The move from make to Ninja might also break a few things, but we can fix those as we discover them.

Otherwise good.

if [[ "$OUTOFTREE" == "true" ]]; then
mkdir -p build
cd build
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed for pixi build? If so, why not just move this logic to pixi.toml itself? That way this simple script can stay build system independent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants