Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing basic_free_stack_if_not_null #2643

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

anutosh491
Copy link
Collaborator

@anutosh491 anutosh491 commented Apr 6, 2024

Addressing #2614 (comment)

We have been using the basic_free_stack out of symengine's C wrapper untill now. But before freeing out variables we need to check if they have been stack allocated previously. Hence this PR aims to replace every basic_free_stack call with

    if (var != NULL) {
        basic_free_stack(var);
    }

@anutosh491
Copy link
Collaborator Author

I tried approach 1 & 2 as mentioned here (#2614 (comment)) but haven't been able to address the example in consideration fully. cc @Thirumalai-Shaktivel could you try helping me out here ?

@certik
Copy link
Contributor

certik commented Apr 29, 2024

@anutosh491 what is the status here --- can you describe what the problem is?

Are you trying to address this comment: #2614 (comment) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants